anuengineer commented on a change in pull request #981: HDDS-1696. RocksDB use separate Write-ahead-log location for OM RocksDB. URL: https://github.com/apache/hadoop/pull/981#discussion_r294540185
########## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java ########## @@ -35,6 +35,7 @@ // metadata dir but in future we may support multiple for redundancy or // performance. public static final String OZONE_SCM_DB_DIRS = "ozone.scm.db.dirs"; + public static final String OZONE_SCM_DB_WAL_DIR = "ozone.scm.db.wal.dir"; Review comment: Do we know that WAL performance is being compromised today ? This adds a new config value, but are we sure about the benefit ? In other words, are we sure that ozone is being bottlenecked by RocksDB? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
