bharatviswa504 commented on a change in pull request #978: HDDS-1694.
TestNodeReportHandler is failing with NPE
URL: https://github.com/apache/hadoop/pull/978#discussion_r294491156
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -221,9 +221,8 @@ public VersionResponse getVersion(SCMVersionRequestProto
versionRequest) {
return VersionResponse.newBuilder()
.setVersion(this.version.getVersion())
.addValue(OzoneConsts.SCM_ID,
- this.scmManager.getScmStorageConfig().getScmId())
- .addValue(OzoneConsts.CLUSTER_ID, this.scmManager.getScmStorageConfig()
- .getClusterID())
+ this.scmStorageConfig.getScmId())
+ .addValue(OzoneConsts.CLUSTER_ID, this.scmStorageConfig.getClusterID())
Review comment:
Minor: We can use clusterID which is set in SCMNodeManager constructor. Or
remove the clusterID and use that from scmStorage. I feel 2nd option will be
good, as to get ScmId we got from scmStorageConfig
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
