steveloughran commented on a change in pull request #951: HADOOP-15183. S3Guard
store becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/951#discussion_r293067787
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -2359,6 +2708,37 @@ public UserGroupInformation getOwner() {
return owner;
}
+ /**
+ * Build an immutable store context.
+ * If called while the FS is being initialized,
+ * some of the context will be incomplete.
+ * new store context instances should be created as appropriate.
+ * @return the store context of this FS.
+ */
+ @InterfaceAudience.Private
+ public StoreContext createStoreContext() {
Review comment:
I must disagree. The builder pattern is best for when you want to have
partial config or support change where you dont want to add many, many
constructors, and substitutes for Java's lack or named params in constructors
(compare with: groovy, scala, python)
Here: all parameters must be supplied and this is exclusively for use in the
s3a connector. Nobody should be creating these elsewhere, and if they do, not
my problem if it breaks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
