steveloughran commented on issue #802: HADOOP-16279. S3Guard: Implement 
time-based (TTL) expiry for entries …
URL: https://github.com/apache/hadoop/pull/802#issuecomment-500450591
 
 
   Some of the getFileStatus-side errors go away when in 
`S3AFileSystem.innerGetFileStatus()` I revert back from
   
   ```
       if (hasMetadataStore()) {
         pm = S3Guard.getWithTtl(metadataStore, path, ttlTimeProvider);
       }
   ```
   
   to 
   ```
       if (hasMetadataStore()) {
         pm = metadataStore.get(path, true);
       }
   ```
   
   But other things do fail; I think what we'll need is something which 
reinstates that get-with-empty-directory option with the TTL.
   
   Anyhow, -1 as is, obviously.
   
   I'm going to put up a branch with my other changes, which combine some of 
the minor style changes and adding etag and version ID checks to the assertions 
about files not matching. Those assertions actually fail on the listings, 
because they aren't always returning etags. I think all our store list 
operations should be returning etags, if they aren't already

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to