bgaborg commented on issue #802: HADOOP-16279. S3Guard: Implement time-based 
(TTL) expiry for entries …
URL: https://github.com/apache/hadoop/pull/802#issuecomment-499106292
 
 
   thanks @steveloughran for reviewing. I've corrected the issues and added 
tests you requested.
   the only thing I left out basically is changing the TtlProvider now to 
ZonedDateTime, because it would mean a bigger modification which can be done 
separately under another jira. Instead, I added to the Javadoc that it is UTC - 
so every internal API user should what it is. Note: this modification does 
*not* involve a public API change or a CLI change, so the new prune operation 
won't be available for use from the CLI. If we want to enable this 
functionality, we should create a new issue for this.
   Running the verify, I'll be back with the results soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to