xiaoyuyao commented on a change in pull request #885: HDDS-1541. Implement
addAcl,removeAcl,setAcl,getAcl for Key. Contributed by Ajay Kumat.
URL: https://github.com/apache/hadoop/pull/885#discussion_r290430512
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -819,6 +829,7 @@ public OmMultipartInfo initiateMultipartUpload(String
volumeName,
.setKeyName(keyName)
.setType(HddsProtos.ReplicationType.valueOf(type.toString()))
.setFactor(HddsProtos.ReplicationFactor.valueOf(factor.getValue()))
+ .setAcls(getAclList())
Review comment:
It seems OmKeyArgs should always set acls to default acls if the builder has
not been explicitly set acls. Why not adding this logic in OmKeyArgs.Builder()
method so that we don't need to populate changes in many places like this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
