elek commented on a change in pull request #895: HDDS-1636. Tracing id is not
propagated via async datanode grpc call
URL: https://github.com/apache/hadoop/pull/895#discussion_r290242450
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java
##########
@@ -99,7 +103,16 @@ public static Scope importAndCreateScope(String name,
String encodedParent) {
if (encodedParent != null && encodedParent.length() > 0) {
StringBuilder builder = new StringBuilder();
builder.append(encodedParent);
- parentSpan = tracer.extract(StringCodec.FORMAT, builder);
+ try {
+ parentSpan = tracer.extract(StringCodec.FORMAT, builder);
+ } catch (Exception ex) {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Can't extract tracing from the message.", ex);
+ } else {
+ LOG.warn(
Review comment:
My log was full with stack traces in case of a problem. I removed the stack
trace from WARN and only the e.getMessage is printed out. I think it should be
enough to notice the problem.
But I have no strong opinion. What do you prefer? WARN + full exception all
the time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
