bharatviswa504 commented on a change in pull request #882: HDDS-1624 : Refactor
operations inside the bucket lock in OM key write.
URL: https://github.com/apache/hadoop/pull/882#discussion_r290069995
##########
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/utils/db/TestTypedRDBTableStore.java
##########
@@ -316,4 +316,22 @@ public void
testTypedTableWithCacheWithFewDeletedOperationType()
}
}
+
+ @Test
+ public void testIsExist() throws Exception {
+ try (Table<String, String> testTable = createTypedTable(
+ "Eighth")) {
+ String key =
+ RandomStringUtils.random(10);
+ String value = RandomStringUtils.random(10);
+ testTable.put(key, value);
+ Assert.assertTrue(testTable.isExist(key));
+
+ String invalidKey = key + RandomStringUtils.random(1);
+ Assert.assertFalse(testTable.isExist(invalidKey));
Review comment:
Can you add a test for adding to cache and then check key exists in the
table also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
