jnp commented on a change in pull request #826: HDDS-1517. AllocateBlock call
fails with ContainerNotFoundException.
URL: https://github.com/apache/hadoop/pull/826#discussion_r285285507
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManager.java
##########
@@ -296,10 +296,10 @@ ContainerInfo allocateContainer(
.setReplicationFactor(pipeline.getFactor())
.setReplicationType(pipeline.getType())
.build();
- pipelineManager.addContainerToPipeline(pipeline.getId(),
Review comment:
Should we also add a comment that this method must be called with lock held
on the pipeline?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
