[
https://issues.apache.org/jira/browse/HADOOP-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lindongdong updated HADOOP-16310:
---------------------------------
Description:
Now, the log of a slow RPC request just contains the
*methodName*,*processingTime* and *client*. Code is here:
{code:java}
if ((rpcMetrics.getProcessingSampleCount() > minSampleSize) &&
(processingTime > threeSigma)) {
if(LOG.isWarnEnabled()) {
String client = CurCall.get().toString();
LOG.warn(
"Slow RPC : " + methodName + " took " + processingTime +
" milliseconds to process from client " + client);
}
rpcMetrics.incrSlowRpc();
}{code}
It is not enough to analyze why the RPC request is slow.
The parameter of the request is a very important thing, and need to be logged.
was:
Now, the log of a slow RPC request just contains the
*methodName*,*processingTime* and *client*. Code is here:
{code:java}
if ((rpcMetrics.getProcessingSampleCount() > minSampleSize) &&
(processingTime > threeSigma)) {
if(LOG.isWarnEnabled()) {
String client = CurCall.get().toString();
LOG.warn(
"Slow RPC : " + methodName + " took " + processingTime +
" milliseconds to process from client " + client);
}
rpcMetrics.incrSlowRpc();
}{code}
It is not enough to analyze why the RPC request is slow.
The parameter of the request is a very important thing, and need to be added to
the log.
> Log of a slow RPC request should contain the parameter of the request
> ---------------------------------------------------------------------
>
> Key: HADOOP-16310
> URL: https://issues.apache.org/jira/browse/HADOOP-16310
> Project: Hadoop Common
> Issue Type: Improvement
> Components: rpc-server
> Affects Versions: 3.1.1, 2.7.7, 3.1.2
> Reporter: lindongdong
> Priority: Minor
>
>
> Now, the log of a slow RPC request just contains the
> *methodName*,*processingTime* and *client*. Code is here:
> {code:java}
> if ((rpcMetrics.getProcessingSampleCount() > minSampleSize) &&
> (processingTime > threeSigma)) {
> if(LOG.isWarnEnabled()) {
> String client = CurCall.get().toString();
> LOG.warn(
> "Slow RPC : " + methodName + " took " + processingTime +
> " milliseconds to process from client " + client);
> }
> rpcMetrics.incrSlowRpc();
> }{code}
>
> It is not enough to analyze why the RPC request is slow.
> The parameter of the request is a very important thing, and need to be logged.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
