hanishakoneru commented on a change in pull request #792: HDDS-1474.
ozone.scm.datanode.id config should take path for a dir
URL: https://github.com/apache/hadoop/pull/792#discussion_r281880291
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -296,11 +296,10 @@
public static final int OZONE_SCM_DEFAULT_PORT =
OZONE_SCM_DATANODE_PORT_DEFAULT;
- // File Name and path where datanode ID is to written to.
+ // The path where datanode ID is to be written to.
// if this value is not set then container startup will fail.
- public static final String OZONE_SCM_DATANODE_ID = "ozone.scm.datanode.id";
-
- public static final String OZONE_SCM_DATANODE_ID_PATH_DEFAULT =
"datanode.id";
+ public static final String OZONE_SCM_DATANODE_ID_DIR =
+ "ozone.scm.datanode.id";
Review comment:
Can we add the "dir" part to the key string also. This is what would be used
to configure this property in clusters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
