[ 
https://issues.apache.org/jira/browse/HADOOP-16059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832509#comment-16832509
 ] 

Daryn Sharp commented on HADOOP-16059:
--------------------------------------

A bit late, but static blocks that throw exceptions can cause very bizarre and 
misleading errors.  Is there any particular reason this:
{code:java}
+ private static SaslClientFactory saslFactory;
+ static {
+    saslFactory = new FastSaslClientFactory(null);
+  }{code}
Isn't this:
{code:java}
+ private static final SaslClientFactory saslFactory = new 
FastSaslClientFactory(null);{code}

> Use SASL Factories Cache to Improve Performance
> -----------------------------------------------
>
>                 Key: HADOOP-16059
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16059
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Critical
>             Fix For: 3.3.0
>
>         Attachments: After-Dn.png, After-Read.png, After-Server.png, 
> After-write.png, Before-DN.png, Before-Read.png, Before-Server.png, 
> Before-Write.png, HADOOP-16059-01.patch, HADOOP-16059-02.patch, 
> HADOOP-16059-02.patch, HADOOP-16059-03.patch, HADOOP-16059-04.patch
>
>
> SASL Client factories can be cached and SASL Server Factories and SASL Client 
> Factories can be together extended at SaslParticipantĀ  to improve performance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to