hunshenshi opened a new pull request #770: 
HDFS-14456:HAState#prepareToEnterState neednt a lock
URL: https://github.com/apache/hadoop/pull/770
 
 
   prepareToEnterState in HAState is called without the context being locked.
   
   But in NameNode#NameNode, prepareToEnterState is after haContext.writeLock()
   
    
   ``` java
   try {
     haContext.writeLock();
     state.prepareToEnterState(haContext);
     state.enterState(haContext);
   } finally {
     haContext.writeUnlock();
   }
   ```
   
   Is it OK?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to