mackrorysd commented on a change in pull request #675: HADOOP-16085: use object
version or etags to protect against inconsistent read after replace/overwrite
URL: https://github.com/apache/hadoop/pull/675#discussion_r276301438
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractS3AMockTest.java
##########
@@ -59,12 +59,14 @@ public void setup() throws Exception {
Configuration conf = new Configuration();
conf.setClass(S3_CLIENT_FACTORY_IMPL, MockS3ClientFactory.class,
S3ClientFactory.class);
- // We explicitly disable MetadataStore even if it's configured. For unit
- // test we don't issue request to AWS DynamoDB service.
- conf.setClass(S3_METADATA_STORE_IMPL, NullMetadataStore.class,
+ // We explicitly use local MetadataStore even if something else is
+ // configured. For unit test we don't issue request to AWS DynamoDB service
+ conf.setClass(S3_METADATA_STORE_IMPL, LocalMetadataStore.class,
Review comment:
IMO this should only be set when -Ds3guard is passed on the command line,
similar to what other tests were doing before. Tests that are only meaningful
with S3Guard should Assume.assumeTrue() on this, but other tests that are
meaningful without it as well should still be getting exercised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
