[
https://issues.apache.org/jira/browse/HADOOP-16254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819026#comment-16819026
]
Vinayakumar B commented on HADOOP-16254:
----------------------------------------
Thanks [~hexiaoqiao] for the patch.
I have skipped through the patch.
I would recommend to have following changes.
# Include complete client's socket address instead of just hostname(i.e.
Hostname/IP:port ). This will help in identifying details about particular
client if required.
# Instead of changing the RPC Request header, add the same field in
"IpcConnectionContextProto" as suggested by [~daryn] in the previous Jira.
Advantage is, IpcConnectionContextProto will be decoded only once during
Connection establishment, where as RpcHeader will be decoded for every RPC,
though the proxy details will be same in every request.
> Add clientHostname to RPC header
> --------------------------------
>
> Key: HADOOP-16254
> URL: https://issues.apache.org/jira/browse/HADOOP-16254
> Project: Hadoop Common
> Issue Type: New Feature
> Components: ipc
> Reporter: He Xiaoqiao
> Assignee: He Xiaoqiao
> Priority: Major
> Attachments: HADOOP-16254.001.patch, HADOOP-16254.002.patch
>
>
> In order to support data locality of RBF, we need to add new field about
> client hostname in the RPC headers of Router protocol calls.
> clientHostname represents hostname of client and forward by Router to
> Namenode to support data locality friendly. See more [RBF Data Locality
> Design|https://issues.apache.org/jira/secure/attachment/12965092/RBF%20Data%20Locality%20Design.pdf]
> in HDFS-13248 and [maillist
> vote|http://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201904.mbox/%3CCAF3Ajax7hGxvowg4K_HVTZeDqC5H=3bfb7mv5sz5mgvadhv...@mail.gmail.com%3E].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]