ben-roling commented on issue #606: HADOOP-16190. S3A copyFile operation to include source versionID or etag in the copy request URL: https://github.com/apache/hadoop/pull/606#issuecomment-482597747 Given you don't have a problem with what I'm doing in #646 going over top of it later, I have no problem with this going in as-is or being patched into older versions. I will also note though that this seems somewhat inconsistent with changes already in S3AInputStream from HADOOP-15625. There we only apply constraints indicated by the fs.s3a.change.detection configuration whereas here you apply constraints regardless of that config. You probably already realize this, but just wanted to be sure. Still, I'm not bothered enough by the inconsistency to say you shouldn't go ahead with it if you like.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
