arp7 commented on a change in pull request #689: HDDS-1379. Convert all OM 
Volume related operations to HA model.
URL: https://github.com/apache/hadoop/pull/689#discussion_r271971191
 
 

 ##########
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/VolumeManagerImpl.java
 ##########
 @@ -255,6 +328,19 @@ public void setQuota(String volume, long quota) throws 
IOException {
     }
   }
 
+  @Override
+  public void applySetQuota(OmVolumeArgs omVolumeArgs) throws IOException {
+    try {
+      String dbVolumeKey = metadataManager.getVolumeKey(
 
 Review comment:
   We should not need to do a read in applySetQuota. Can we pass the 
dbVolumeKey from start to apply?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to