jiwq commented on a change in pull request #458: YARN-8246 winutils - fix
failure to retrieve disk and network perf co…
URL: https://github.com/apache/hadoop/pull/458#discussion_r271382850
##########
File path: hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
##########
@@ -161,25 +161,25 @@ int GetDiskAndNetwork(LONGLONG* diskRead, LONGLONG*
diskWrite, LONGLONG* netRead
}
// Add each one of the counters with wild cards
- if(status = PdhAddCounter(hQuery, COUNTER_PATH_NET_READ_ALL, 0,
&hCounterNetRead))
+ if(status = PdhAddEnglishCounter(hQuery, COUNTER_PATH_NET_READ_ALL, 0,
&hCounterNetRead))
Review comment:
```suggestion
if (status = PdhAddEnglishCounter(hQuery, COUNTER_PATH_NET_READ_ALL, 0,
&hCounterNetRead))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
