[
https://issues.apache.org/jira/browse/HADOOP-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795081#comment-16795081
]
Daniel Templeton commented on HADOOP-16156:
-------------------------------------------
Thanks for the patch, [~shwetayakkali]. A few comments:
# You deleted this line:{code} int numOfLeaves =
child.getNumOfLeaves();{code} I don't think that's correct. I assume you were
trying to resolve a complaint about the local variable hiding a class variable.
That's not how to fix it. It's also out of scope for this patch, so I'd leave
it alone.
# You need a space before the brace here:{code} if (index !=-1) {{code}
# You need a newline before the brace here:{code} return children; }{code}
> [Clean-up] Remove NULL check before instanceof and fix checkstyle in
> InnerNodeImpl
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-16156
> URL: https://issues.apache.org/jira/browse/HADOOP-16156
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Shweta
> Assignee: Shweta
> Priority: Minor
> Attachments: HADOOP-16156.001.patch, HADOOP-16156.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
