[
https://issues.apache.org/jira/browse/HADOOP-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788775#comment-16788775
]
Steve Loughran commented on HADOOP-15942:
-----------------------------------------
checkstyle is unhappy, I'm afraid
{code}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/jmx/JMXJsonServlet.java:361:
LOG.error("getting attribute {} of {} threw an exception",attName,oname,e);:
'catch' child has incorrect indentation level 1, expected level should be 6.
[Indentation]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/jmx/JMXJsonServlet.java:361:
LOG.error("getting attribute {} of {} threw an
exception",attName,oname,e);:59: ',' is not followed by whitespace.
[WhitespaceAfter]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/jmx/JMXJsonServlet.java:361:
LOG.error("getting attribute {} of {} threw an
exception",attName,oname,e);:67: ',' is not followed by whitespace.
[WhitespaceAfter]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/jmx/JMXJsonServlet.java:361:
LOG.error("getting attribute {} of {} threw an
exception",attName,oname,e);:73: ',' is not followed by whitespace.
[WhitespaceAfter]
{code}
> Change the logging level form DEBUG to ERROR for RuntimeErrorException in
> JMXJsonServlet
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-15942
> URL: https://issues.apache.org/jira/browse/HADOOP-15942
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.1.0
> Reporter: Anuhan Torgonshar
> Priority: Major
> Labels: easyfix
> Attachments: HADOOP-15942.trunk.patch
>
>
> In *JMXJsonServlet.java* file, when invokes *MBeanServer.getAttribute()*
> method, many catch clauses followed, and each of them contains a log
> statement, most of them set the logging level to *ERROR*. However, when
> catches *RuntimeErrorException* in line 348 (r1839798), the logging level of
> log statement in this catch clause is *DEBUG*, the annotation indicates that
> an unexpected failure occured in getAttribute method before, so I think the
> logging level shuold be *ERROR* level too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
