[
https://issues.apache.org/jira/browse/HADOOP-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769565#comment-16769565
]
Wei-Chiu Chuang commented on HADOOP-15979:
------------------------------------------
Thanks a lot for the patch, [~daryn]!
The shading stuff will need an update, like what I mentioned in HADOOP-15978.
At first pass, it looked to me the variable sendParamsExecutor is no longer
used.
{{NioIpcStreams#submit()}} calls {{Client.getClientExecutor()}} which returns
{{Client.clientExcecutorFactory.clientExecutor}}. But it is not initialized,
unless you call {{clientExcecutorFactory.refAndGetInstance()}}.
Simply put, shouldn't {{NioIpcStreams#submit()}} call
{{sendParamsExecutor.submit()}} instead?
It doesn't fail tests because each Client object initializes sendParamsExecutor
which initializes Client.clientExcecutorFactory.clientExecutor properly. But if
I remove sendParamsExecutor from the code (because it appears not used), it
breaks tests.
> Add Netty support to the RPC client
> -----------------------------------
>
> Key: HADOOP-15979
> URL: https://issues.apache.org/jira/browse/HADOOP-15979
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc, security
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Major
> Attachments: HADOOP-15979.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much
> better performance than that offered by Java's SSLEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
