[
https://issues.apache.org/jira/browse/HADOOP-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765031#comment-16765031
]
Steve Loughran commented on HADOOP-16093:
-----------------------------------------
# can we keep "DurationInfo" with the same name? As well as reducing the size
of the diff, it avoids the problem that a lot of the changed lines will get too
long.
# Both it and OperationDuration will need a javadoc I'm afraid.
# check your IDE's settings on imports. All the org.apache entries should come
in their own section...in this patch they're being moved up into that previous
section.
It's going to need some tests now, isn't it? Something like
* create one, assert that its completed duration is always >= 0
* create one, sleep for a few seconds, assert that the duration is now > 0
* close it twice, verify all is well
* pass in null as the message to log. What should we do there? Ignore? Fail?
> Move DurationInfo from hadoop-aws to hadoop-common org.apache.fs.impl
> ---------------------------------------------------------------------
>
> Key: HADOOP-16093
> URL: https://issues.apache.org/jira/browse/HADOOP-16093
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, util
> Reporter: Steve Loughran
> Assignee: Abhishek Modi
> Priority: Minor
> Attachments: HADOOP-16093.001.patch, HADOOP-16093.002.patch,
> HADOOP-16093.003.patch, HADOOP-16093.004.patch
>
>
> It'd be useful to have DurationInfo usable in other places (e.g. distcp,
> abfs, ...). But as it is in hadoop-aws under
> {{org.apache.hadoop.fs.s3a.commit.DurationInfo
> org.apache.hadoop.fs.s3a.commit.DurationInfo}} we can't do that
> Move it.
> We'll have to rename the Duration class in the process, as java 8 time has a
> class of that name too. Maybe "OperationDuration", with DurationInfo a
> subclass of that
> Probably need a test too, won't it?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
