[ 
https://issues.apache.org/jira/browse/HADOOP-15566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752975#comment-16752975
 ] 

Elek, Marton commented on HADOOP-15566:
---------------------------------------

Thanks the idea [~cmccabe]. It's interesting.

Fix me If I am wrong, but as I see the HTrace is not designed to be extensible. 
For example the Span is an interface but Tracer always creates the MilliSpan 
implementation. To use HTrace as a lightweight layer and support multiple 
tracing implementation (such as opentracing or opencensus) we need to refactor 
the HTrace code. I have two problems with this approach:

 1) The new refactored HTrace won't be compatible the old HTrace. Would be hard 
to support old HTrace.

 2) It wold be equivalent to resurrect the HTrace which is voted to retire. 
(The some thing can be done without importing HTrace code to the Hadoop but 
refactor it on the HTrace side)

But it's a valid concern about creating a new layer (even if Cassandra also 
followed this approach as @mck wrote it). For me it's hard to compare the 
complexity of maintain an own lightweight abstraction layer and maintaining 
HTrace. (Even if the first one seems to be easier).

I think the real alternative here is just to use OpenTracing (despite the 
concerns about the governance raised by [~michaelsembwever]) And follow the 
approach which is prototyped by [~jojochuang], [~fabbri], [~rizaon])

Or (as a first step) it could be added to the existing HTrace code, 
side-by-side, to evaluate it.

 

 

 

 

 

 

> Remove HTrace support
> ---------------------
>
>                 Key: HADOOP-15566
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15566
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 3.1.0
>            Reporter: Todd Lipcon
>            Priority: Major
>              Labels: security
>         Attachments: Screen Shot 2018-06-29 at 11.59.16 AM.png, 
> ss-trace-s3a.png
>
>
> The HTrace incubator project has voted to retire itself and won't be making 
> further releases. The Hadoop project currently has various hooks with HTrace. 
> It seems in some cases (eg HDFS-13702) these hooks have had measurable 
> performance overhead. Given these two factors, I think we should consider 
> removing the HTrace integration. If there is someone willing to do the work, 
> replacing it with OpenTracing might be a better choice since there is an 
> active community.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to