[
https://issues.apache.org/jira/browse/HADOOP-15920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743072#comment-16743072
]
Steve Loughran edited comment on HADOOP-15920 at 1/15/19 1:49 PM:
------------------------------------------------------------------
-1 as is, but it's not far off
* checkstyle is complaining about there not being spaces after commas in
argument lists: please add on the new lines, especially all the new assertEquals
* Don't see anything else to worry about
Please can you update and resubmit a new patch to get checkstyle happy, and
retest against your normal S3 endpoint. Then I'll take a final look at it
thanks
was (Author: [email protected]):
Just tried appliying this; git apply didn't like it, and patch
> get patch for S3a nextReadPos(), through Yetus
> ----------------------------------------------
>
> Key: HADOOP-15920
> URL: https://issues.apache.org/jira/browse/HADOOP-15920
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: 3.1.1
> Reporter: Steve Loughran
> Assignee: lqjacklee
> Priority: Major
> Attachments: HADOOP-15870-001.diff, HADOOP-15870-002.patch,
> HADOOP-15870-003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
