[
https://issues.apache.org/jira/browse/HADOOP-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617233#comment-16617233
]
Sunil Govindan commented on HADOOP-15009:
-----------------------------------------
This change seems fine to me. But I have nt tested the feature with this patch.
[~subru], cud u pls help to check whether this patch works as expected.
[~leftnoteasy], cud u pls take one look to the script change. As we crossed the
code freeze date, I would like to take a decision on getting this to 3.2.
> hadoop-resourceestimator's shell scripts are a mess
> ---------------------------------------------------
>
> Key: HADOOP-15009
> URL: https://issues.apache.org/jira/browse/HADOOP-15009
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts, tools
> Affects Versions: 3.1.0
> Reporter: Allen Wittenauer
> Assignee: Ajay Kumar
> Priority: Blocker
> Attachments: HADOOP-15009.001.patch, Screen Shot 2017-12-12 at
> 11.16.23 AM.png
>
>
> #1:
> There's no reason for estimator.sh to exist. Just make it a subcommand under
> yarn or whatever.
> #2:
> In it's current form, it's missing a BUNCH of boilerplate that makes certain
> functionality completely fail.
> #3
> start/stop-estimator.sh is full of copypasta that doesn't actually do
> anything/work correctly. Additionally, if estimator.sh doesn't exist,
> neither does this since yarn --daemon start/stop will do everything as
> necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
