[
https://issues.apache.org/jira/browse/HADOOP-15674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583010#comment-16583010
]
Xiao Chen commented on HADOOP-15674:
------------------------------------
Thanks for the work here [~snemeth] and [~gabor.bota] for reviewing!
Unfortunately, patch 3 looks to have accidentally included FSNamesystem.java
changes. Could you pull it out?
Since we will need a new rev, I have another minor comment on the patch:
I think the standard way to unset a property is
{code:java}
System.clearProperty(key);{code}
rather than
{code:java}
System.setProperty(key, "");{code}
Lastly, a patch specific to a branch is only needed if there is backport
conflicts. I tried the trunk patch, and it can be cleanly backported all the
way to branch-2.9 (and have conflicts when backporting to branch-2.8). So, no
need to generate branch-3 and branch-2 patches. If the conflicts were
non-trivial I would ask for a branch-2.8 patch, but given it is pretty easy to
resolve, I'll just take care of it at commit time.
> Test failure TestSSLHttpServer.testExcludedCiphers with
> TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 cipher suite
> ----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-15674
> URL: https://issues.apache.org/jira/browse/HADOOP-15674
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 2.6.0
> Reporter: Gabor Bota
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: HADOOP-15674-branch-2.001.patch,
> HADOOP-15674-branch-2.002.patch, HADOOP-15674-branch-2.003.patch,
> HADOOP-15674-branch-3.0.0.001.patch, HADOOP-15674-branch-3.0.0.002.patch,
> HADOOP-15674-branch-3.0.0.003.patch, HADOOP-15674.001.patch,
> HADOOP-15674.002.patch, HADOOP-15674.003.patch
>
>
> Running {{hadoop/hadoop-common-project/hadoop-common# mvn test
> -Dtest="TestSSLHttpServer#testExcludedCiphers" -Dhttps.protocols=TLSv1.2
> -Dhttps.cipherSuites=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256}} fails with:
> {noformat}
> Error Message
> No Ciphers in common, SSLHandshake must fail.
> Stacktrace
> java.lang.AssertionError: No Ciphers in common, SSLHandshake must fail.
> at org.junit.Assert.fail(Assert.java:88)
> at
> org.apache.hadoop.http.TestSSLHttpServer.testExcludedCiphers(TestSSLHttpServer.java:178)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
