[
https://issues.apache.org/jira/browse/HADOOP-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Da Zhou updated HADOOP-15546:
-----------------------------
Attachment: HADOOP-15546-HADOOP-15407-010.patch
Status: Patch Available (was: Open)
HADOOP-15546 patch 010:
1. Updated {{equals()}} method in {{VersionedFileStatus}}: if
versionedfilestatus is comparing to a class inherited from {{FileStatus}}, then
only path is compared.
2. Remove code which created user working dir when initializing
AzureBlobFileSystem, related tests are updated.
3. Updated test
{{ITestAzureBlobFileSystemFileStatus.testEnsureStatusWorksForRoot()}} because
of 2.
4. Removed {{testRenameFileUsingUnicode()}} from
{{ITestAzureBlobFileSystemRename}}, because it is a duplicate of
{{ITestAzureBlobFileSystemRenameUnicode}}.
5. Updated {{testRenameFileUsingUnicode()}} in
{{ITestAzureBlobFileSystemRenameUnicode}}:
- This test failed for the fifth test data set: the test parameter value was
an absolute path of a file, but the test logic required it to be just file name.
- {{new Path(pathString)}} will fail if pathString doesn't start "/" and
contains ":", URISyntaxException will occur for that case. Because of this
issue, "{{new Path(parent, fileName)}}" failed for the fifth test data which
contains ":".
Provided a work around: use "/" to concatenate parent name and file name to
construct the file Path.
Tested with US west account, below are results of the wasb and abfs tests:
{noformat}
mvn -T 1C -Dparallel-tests -DtestsThreadCount=8 clean verify
[INFO] --- maven-surefire-plugin:2.21.0:test (default-test) @ hadoop-azure ---
Tests run: 257, Failures: 0, Errors: 0, Skipped: 11
[INFO] --- maven-surefire-plugin:2.21.0:test (serialized-test) @ hadoop-azure
---
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] --- maven-failsafe-plugin:2.21.0:integration-test
(default-integration-test) @ hadoop-azure ---
Tests run: 774, Failures: 0, Errors: 0, Skipped: 98
[INFO] --- maven-failsafe-plugin:2.21.0:integration-test
(sequential-integration-tests) @ hadoop-azure ---
Tests run: 186, Failures: 0, Errors: 0, Skipped: 10
[INFO] BUILD SUCCESS
{noformat}
> ABFS: tune imports & javadocs; stabilise tests
> ----------------------------------------------
>
> Key: HADOOP-15546
> URL: https://issues.apache.org/jira/browse/HADOOP-15546
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: HADOOP-15407
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Attachments: HADOOP-15546-001.patch,
> HADOOP-15546-HADOOP-15407-001.patch, HADOOP-15546-HADOOP-15407-002.patch,
> HADOOP-15546-HADOOP-15407-003.patch, HADOOP-15546-HADOOP-15407-004.patch,
> HADOOP-15546-HADOOP-15407-005.patch, HADOOP-15546-HADOOP-15407-006.patch,
> HADOOP-15546-HADOOP-15407-006.patch, HADOOP-15546-HADOOP-15407-007.patch,
> HADOOP-15546-HADOOP-15407-008.patch, HADOOP-15546-HADOOP-15407-009.patch,
> HADOOP-15546-HADOOP-15407-010.patch, azure-auth-keys.xml
>
>
> Followup on HADOOP-15540 with some initial review tuning
> h2. Tuning
> * ordering of imports
> * rely on azure-auth-keys.xml to store credentials (change imports,
> docs,.gitignore)
> * log4j -> info
> * add a "." to the first sentence of all the javadocs I noticed.
> * remove @Public annotations except for some constants (which includes some
> commitment to maintain them).
> * move the AbstractFS declarations out of the src/test/resources XML file
> into core-default.xml for all to use
> * other IDE-suggested tweaks
> h2. Testing
> Review the tests, move to ContractTestUtil assertions, make more consistent
> to contract test setup, and general work to make the tests work well over
> slower links, document, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
