[
https://issues.apache.org/jira/browse/HADOOP-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548291#comment-16548291
]
Sean Mackrory commented on HADOOP-15546:
----------------------------------------
The patch looks pretty good to me from a code standpoint, and fixes a couple of
things I initially added to my list of to-dos (like some of the config file
inconsistency and imports). One nit: on line 2619 of the latest patch, the
config key is missing the second 's' in 'abfss':
{code}
+<property>
+ <name>fs.contract.test.fs.abfs</name> <!-- SHOULD BE abfss! -->
+ <value>abfss://[email protected]</value>
+ <description>Container for contract tests</description>
+</property>
{code}
I'm having some serious issues running with this patch that I need to track
down. I thought I had everything set up correctly because without this patch I
can run the tests and I have 2-3 failures, depending on the run. With this
patch, most of them fail because the URL they're trying doesn't exist. Trying
to track down why. I've symlinked between azure-auth-keys.xml and
azure-bfs-auth-keys.xml, and manually messed with that, so I don't *think* it's
just not finding my configs, but I'll need to dig more.
> ABFS: tune imports & javadocs; stabilise tests
> ----------------------------------------------
>
> Key: HADOOP-15546
> URL: https://issues.apache.org/jira/browse/HADOOP-15546
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: HADOOP-15407
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Attachments: HADOOP-15546-001.patch,
> HADOOP-15546-HADOOP-15407-001.patch, HADOOP-15546-HADOOP-15407-002.patch,
> HADOOP-15546-HADOOP-15407-003.patch, HADOOP-15546-HADOOP-15407-004.patch,
> HADOOP-15546-HADOOP-15407-005.patch, HADOOP-15546-HADOOP-15407-006.patch,
> HADOOP-15546-HADOOP-15407-006.patch
>
>
> Followup on HADOOP-15540 with some initial review tuning
> h2. Tuning
> * ordering of imports
> * rely on azure-auth-keys.xml to store credentials (change imports,
> docs,.gitignore)
> * log4j -> info
> * add a "." to the first sentence of all the javadocs I noticed.
> * remove @Public annotations except for some constants (which includes some
> commitment to maintain them).
> * move the AbstractFS declarations out of the src/test/resources XML file
> into core-default.xml for all to use
> * other IDE-suggested tweaks
> h2. Testing
> Review the tests, move to ContractTestUtil assertions, make more consistent
> to contract test setup, and general work to make the tests work well over
> slower links, document, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
