[
https://issues.apache.org/jira/browse/HADOOP-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533057#comment-16533057
]
Steve Loughran edited comment on HADOOP-15546 at 7/4/18 8:59 PM:
-----------------------------------------------------------------
HADOOP-15546 patch 003
* assume messages are meaningful when config is incorrect/incomplete
* URI errors reported meaningfully. Changed text of InvalidUriException so it
parses well from all constructed copies.
* ABFS toString() useful in logs and assertions
* VersionedFileStatus.toString() to include version as well as all FileStatus
fields.
ITestAzureBlobFileSystemFileStatus fixed to
* pass when owner != group (ie. stevel/staff)
* split file and root validation into two methods
* validate root group too
I've then gone and broken
{{ITestAzureBlobFileSystemFileStatus.testEnsureStatusWorksForRoot()}} by
verifying that
{code:java}
fs.listStatus("/")[0].equals(fs.getFileStatus("/"))
{code}
Normally FileStatus.equals only compares paths, not here, and the version
fields don't match.. I do not know the larger-scale implications of this
inequality.
Tested: Azure ireland. Got {{ITestAzureBlobFileSystemFileStatus}} to work
excluding the new assertion added.
was (Author: [email protected]):
HADOOP-15546 patch 003
* assume messages are meaningful when config is incorrect/incomplete
* URI errors reported meaningfully. Changed text of InvalidUriException so it
parses well from all constructed copies.
* ABFS toString() useful in logs and assertions
* VersionedFileStatus.toString() to include version as well as all FileStatus
fields.
ITestAzureBlobFileSystemFileStatus fixed to
* pass when owner != group (ie. stevel/staff)
* split file and root validation into two methods
* validate root group too
I've then gone and broken
{{ITestAzureBlobFileSystemFileStatus.testEnsureStatusWorksForRoot()}} by
verifying that {fs.listStatus("/")[0].equals(fs.getFileStatus("/"))}}.
Normally FileStatus.equals only compares paths, not here, and the version
fields don't match.. I do not know the larger-scale implications of this
inequality.
Tested: Azure ireland. Got {{ITestAzureBlobFileSystemFileStatus}} to work
excluding the new assertion added.
> ABFS: tune imports & javadocs; stabilise tests
> ----------------------------------------------
>
> Key: HADOOP-15546
> URL: https://issues.apache.org/jira/browse/HADOOP-15546
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: HADOOP-15407
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Attachments: HADOOP-15546-001.patch,
> HADOOP-15546-HADOOP-15407-001.patch, HADOOP-15546-HADOOP-15407-002.patch,
> HADOOP-15546-HADOOP-15407-003.patch
>
>
> Followup on HADOOP-15540 with some initial review tuning
> * ordering of imports
> * rely on azure-auth-keys.xml to store credentials (change imports,
> docs,.gitignore)
> * log4j -> info
> * add a "." to the first sentence of all the javadocs I noticed.
> * remove @Public annotations except for some constants (which includes some
> commitment to maintain them).
> * move the AbstractFS declarations out of the src/test/resources XML file
> into core-default.xml for all to use
> * other IDE-suggested tweaks
> No actual code changes here; just setting things up better for >1 person
> editing & testing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
