[ 
https://issues.apache.org/jira/browse/HADOOP-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471670#comment-16471670
 ] 

Elek, Marton commented on HADOOP-15456:
---------------------------------------

Thank you [~ajayydv] to work on this. I think it's a very valueable change and 
it will be usefull not just for HDDS-10 but to test any security related 
HDFS/YARN issue from docker.

Therefore I suggest to updated the apache/hadoop-runner image instead of 
creating a new one. The source of that image is on docker-hadoop-runner branch. 
I just created a diff based on your tar and uploaded it to this issue.

Some small comments:

1. As I see the only non compatible change between the existing 
apache/hadoop-runner and your base image is that you removed the 'USER hadoop'. 
Is there any reason for that?

2. There are some commented out code in the starter.sh. (eg. keystore 
download). If we don't need the wire encryptiom yet, we can simply just remove 
those lines. Also there are other disabled lines (sleep, volume permission 
fix). I am just wondering if they ara intentional

3. You have a loop to wait for the KDC server. I really like it as it makes it 
more safe to start the kerberized containers. Just two note: The loop should be 
executed IMHO only if KERBEROS SERVER is set. + You can add the 'KDC' word to 
the print out in the else case to make it easier to understand that we are 
waiting for the KDC...

4. If it will be a shared runner image for both hadoop/hdds/hdfs/yarn, the 
readme should be adjusted a little.


> create base image for running secure ozone cluster
> --------------------------------------------------
>
>                 Key: HADOOP-15456
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15456
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>         Attachments: HADOOP-15456-docker-hadoop-runner.001.patch, 
> secure-ozone.tar
>
>
> Create docker image to run secure ozone cluster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to