[
https://issues.apache.org/jira/browse/HADOOP-15382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444391#comment-16444391
]
Wei-Chiu Chuang commented on HADOOP-15382:
------------------------------------------
Looks good to me overall. Thank you.
Would you please use parameterized logging? I.e. LOG.debug("{}", output);
+1 after that.
This may be useful when kinit is successful. Makes sense to me to log it in
debug level. If kinit is not successful, Shell.execCommand() throws
ExitCodeException with the stderr output in the exception message.
> Log kinit output in credential renewal thread
> ---------------------------------------------
>
> Key: HADOOP-15382
> URL: https://issues.apache.org/jira/browse/HADOOP-15382
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Wei-Chiu Chuang
> Assignee: Gabor Bota
> Priority: Minor
> Attachments: HADOOP-15382.001.patch
>
>
> We currently run kinit command in a thread to renew kerberos credentials
> periodically.
> {code:java}
> Shell.execCommand(cmd, "-R");
> if (LOG.isDebugEnabled()) {
> LOG.debug("renewed ticket");
> }
> {code}
> It seems useful to log the output of the kinit too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
