[
https://issues.apache.org/jira/browse/HADOOP-14756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443981#comment-16443981
]
Gabor Bota edited comment on HADOOP-14756 at 4/19/18 12:27 PM:
---------------------------------------------------------------
Thanks [~fabbri]!
The things I modified in .003:
* added "for debugging and testing only" to MetadataStore#getDiagnostics javadoc
* moved the assertTrue(dirMeta.isAuthoritative()); to the end of the test -
where it should be to test the listing of children elements. This, of course,
broke the test for DynamoDBMetadataStore, so I've
* changed the PERSISTS_AUTHORITATIVE_BIT to false in DynamoDBMetadataStore.
* removed the assert for allowMissing() from the beginning of the test. I think
this is a kind of check which could be easily misunderstood. The reason that I
wanted to include this is that the javadoc for it is slightly misleading:
"Tests assume that implementations will return recently set results", and I
need recently set test result for my tests obviously - so I wanted to check
that.
(Test & verify ran on us-west-2 successfully for the patch.)
was (Author: gabor.bota):
Thanks [~fabbri]!
The things I modified in .003:
* added "for debugging and testing only" to MetadataStore#getDiagnostics javadoc
* moved the assertTrue(dirMeta.isAuthoritative()); to the end of the test -
where it should be to test the listing of children elements. This, of course,
broke the test for DynamoDBMetadataStore, so I've
* changed the PERSISTS_AUTHORITATIVE_BIT to false in DynamoDBMetadataStore.
* removed the assert for allowMissing() from the beginning of the test. I think
this is check which could be easily misunderstood. The reason that I wanted to
include this is that the javadoc for it is slightly misleading: "Tests assume
that implementations will return recently set results", and I need recently set
test result for my tests obviously - so I wanted to check that.
(Test & verify ran on us-west-2 successfully for the patch.)
> S3Guard: expose capability query in MetadataStore and add tests of
> authoritative mode
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-14756
> URL: https://issues.apache.org/jira/browse/HADOOP-14756
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0-beta1
> Reporter: Steve Loughran
> Assignee: Gabor Bota
> Priority: Major
> Attachments: HADOOP-14756.001.patch, HADOOP-14756.002.patch,
> HADOOP-14756.003.patch
>
>
> {{MetadataStoreTestBase.testListChildren}} would be improved with the ability
> to query the features offered by the store, and the outcome of {{put()}}, so
> probe the correctness of the authoritative mode
> # Add predicate to MetadataStore interface
> {{supportsAuthoritativeDirectories()}} or similar
> # If #1 is true, assert that directory is fully cached after changes
> # Add "isNew" flag to MetadataStore.put(DirListingMetadata); use to verify
> when changes are made
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
