[
https://issues.apache.org/jira/browse/HADOOP-14756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437346#comment-16437346
]
Gabor Bota commented on HADOOP-14756:
-------------------------------------
I've uploaded a new patch, and I also have some questions:
* Right now the MetadataStore#getDiagnostics javadoc describes that the
information from the returned map is for debugging only. If this information
still valid? If it is true, is it really a good place to store capabilities
then?
* I use final class with private constructor for MetadataStoreCapabilities - to
store constants because I've seen in the project this is the general way (e.g
org.apache.hadoop.fs.s3a.Constants) to store constants. Is this sufficient, or
should I use interface - where all String constants are public static final by
default? Which choice is preferred?
(Test & verify ran on us-west-2 successfully for the patch.)
> S3Guard: expose capability query in MetadataStore and add tests of
> authoritative mode
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-14756
> URL: https://issues.apache.org/jira/browse/HADOOP-14756
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0-beta1
> Reporter: Steve Loughran
> Assignee: Gabor Bota
> Priority: Major
> Attachments: HADOOP-14756.001.patch, HADOOP-14756.002.patch
>
>
> {{MetadataStoreTestBase.testListChildren}} would be improved with the ability
> to query the features offered by the store, and the outcome of {{put()}}, so
> probe the correctness of the authoritative mode
> # Add predicate to MetadataStore interface
> {{supportsAuthoritativeDirectories()}} or similar
> # If #1 is true, assert that directory is fully cached after changes
> # Add "isNew" flag to MetadataStore.put(DirListingMetadata); use to verify
> when changes are made
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
