[
https://issues.apache.org/jira/browse/HADOOP-15340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432785#comment-16432785
]
Hudson commented on HADOOP-15340:
---------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13958 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/13958/])
HADOOP-15340. Provide meaningful RPC server name for RpcMetrics. (xyao: rev
8ab776d61e569c12ec62024415ff68e5d3b10141)
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
* (edit)
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
> Provide meaningful RPC server name for RpcMetrics
> -------------------------------------------------
>
> Key: HADOOP-15340
> URL: https://issues.apache.org/jira/browse/HADOOP-15340
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.2.0
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 3.2.0
>
> Attachments: HADOOP-15340.001.patch, HADOOP-15340.002.patch,
> HADOOP-15340.003.patch
>
>
> In case of multiple RPC servers in the same JVM it's hard to identify the
> metric data. The only available information as of now is the port number.
> Server name is also added in the constructor of Server.java but it's not used
> at all.
> This patch fix this behaviour:
> 1. The server name is saved to a field in Server.java (constructor signature
> is not changed)
> 2. ServerName is added as a tag to the metrics in RpcMetrics
> 3. The naming convention for the severs are fix.
> About 3: if the server name is not defined the current code tries to identify
> the name from the class name. Which is not always an easy task as in some
> cases the server has a protobuf generated dirty name which also could be an
> inner class.
> The patch also improved the detection of the name (if it's not defined). It's
> a compatible change as the current name is not user ad all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
