[
https://issues.apache.org/jira/browse/HADOOP-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369203#comment-16369203
]
Steve Loughran commented on HADOOP-15146:
-----------------------------------------
We are nearly there!
h3. TestDataByteBuffers
if the asserts are being de-indented by 1, this is a good time to do the same
for the case: statements. I know it's not a set of lines you've changed, but it
makes for a harder read right now, and the hadoop style rules really expect.
This is what Checkstyle is complaining about.
h3. TestTaskID
Order of imports in the other tests should put java & javax imports in their
own group, directly under the package. thanks
{code}
package org.apache.hadoop.mapreduce;
import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;
import java.nio.ByteBuffer;
import org.apache.hadoop.io.DataInputByteBuffer;
import org.apache.hadoop.io.WritableUtils;
import org.junit.Test;
import static org.junit.Assert.*;
{code}
> Remove DataOutputByteBuffer
> ---------------------------
>
> Key: HADOOP-15146
> URL: https://issues.apache.org/jira/browse/HADOOP-15146
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HADOOP-15146.1.patch, HADOOP-15146.2.patch,
> HADOOP-15146.3.patch, HADOOP-15146.4.patch
>
>
> I can't seem to find any references to {{DataOutputByteBuffer}} maybe it
> should be deprecated or simply removed?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
