[
https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281172#comment-16281172
]
Xiao Chen commented on HADOOP-15056:
------------------------------------
Thanks for promptly revving [~jackbearden]! Looks good to me overall.
A few nits:
- This change looks unnecessary, let's not touch it here.
{code}
if (in instanceof StreamCapabilities
&& ((StreamCapabilities) in).hasCapability(
- StreamCapabilities.UNBUFFER)) {
+ StreamCapabilities.UNBUFFER)) {
{code}
- Sorry I wasn't clear. I was hoping the message of
{{UnsupportedOperationException}} still contains inner stream's class name. The
rest of the text looks great.
- Can we define the message as a constant string variable in
{{StreamCapabilitiesPolicy}}, and verify it in the test?
It seems pre-commit is still running at
https://builds.apache.org/job/PreCommit-HADOOP-Build/13795, okay to address
this after it's back.
> Fix TestUnbuffer#testUnbufferException failure
> ----------------------------------------------
>
> Key: HADOOP-15056
> URL: https://issues.apache.org/jira/browse/HADOOP-15056
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: Jack Bearden
> Assignee: Jack Bearden
> Priority: Minor
> Attachments: HADOOP-15056.001.patch, HADOOP-15056.002.patch,
> HADOOP-15056.003.patch, HADOOP-15056.004.patch, HADOOP-15056.005.patch
>
>
> Hello! I am a new contributor and actually contributing to open source for
> the very first time. :)
> I pulled down Hadoop today and when running the tests I encountered a failure
> with the TestUnbuffer#testUnbufferException test.
> The unbuffer code has recently gone through some changes and I believe this
> test case may have been overlooked. Using today's git commit
> (659e85e304d070f9908a96cf6a0e1cbafde6a434), and upon running the test case,
> there is an expect mock for an exception UnsupportedOperationException that
> is no longer being thrown.
> It would appear that a test like this would be valuable so my initial
> proposed patch did not remove it. Instead, I removed the conditions that were
> guarding the cast from being able to fire -- as was the previous behavior.
> Now when we encounter an object that doesn't have the UNBUFFERED
> StreamCapability, it will throw an error as it did prior to the recent
> changes.
> Please review and let me know what you think! :D
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
