[
https://issues.apache.org/jira/browse/HADOOP-14776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128543#comment-16128543
]
Steve Loughran commented on HADOOP-14776:
-----------------------------------------
-1
I was thinking of the tests {{testMkdirsWithUmask}} {{testMoveDirUnderParent}}
The method {{getTestBaseDir}} is explicitly overriden to guarantee that the
paths used for tests is unique to a specific fork, even when run in parallel.
Without that, these tests would interfere with other test.
Now, we have a strict policy regarding patches to hadoop-aws, hadoop-azure & c,
which is "submitter must run all tests and declare the s3 endpoint used"
see:
https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/testing.md
I don't think you've done that here, not just because you didn't declare it,
but because the test path changes would have caused 1+ test to fail. Please,
follow the process...when you turn parallelisation on {{mvn verify
-Dparallel-tests -DtestsThreadCount=6 }} it takes < 10 minutes, even long haul.
Without that assertion that you have run the tests, and where. patches to aws
don't get reviewed. We cant -jenkins doesn't run things, so we mandate
submitter-checks-first policy. The committers should do a final test run after
applying the patch, but submitters are required to get the tests running
themselves first
> clean up ITestS3AFileSystemContract
> -----------------------------------
>
> Key: HADOOP-14776
> URL: https://issues.apache.org/jira/browse/HADOOP-14776
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: 2.9.0
> Reporter: Steve Loughran
> Assignee: Ajay Kumar
> Priority: Minor
> Attachments: HADOOP-14776.01.patch
>
>
> With the move of {{FileSystemContractTest}} test to JUnit4, the bits of
> {{ITestS3AFileSystemContract}} which override existing methods just to skip
> them can be cleaned up: The subclasses could throw assume() so their skippage
> gets noted.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
