[
https://issues.apache.org/jira/browse/HADOOP-13595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109889#comment-16109889
]
Sean Mackrory edited comment on HADOOP-13595 at 8/1/17 10:22 PM:
-----------------------------------------------------------------
[~aw] - I just reviewed this and did some testing. I'm mostly supportive, but a
couple of issues:
- Are you aware the .bats files are missing from your latest patch?
- Instead of appending "-type" to the section headings in the output, what
about " Commands". I think "Admin Commands", "Client Commands" and "Daemon
Commands" would be much clearer than "Admin-type", "Client-type", and
"Daemon-type". Thoughts?
If we consider bash functions to be covered by the term "CLI programs" then
we're breaking compatibility even in a major release, but other than that the
only thing changing is the help output, so I don't think there's actually a
compatibility concern here. But I'm a +1 to put this in beta-1 anyway, if we
can address the two points above.
was (Author: mackrorysd):
[~aw] - I just reviewed this and did some testing. I'm mostly supportive, but a
couple of issues:
- Are you aware the .bats files are missing from your latest patch?
- Instead of appening -type to the section headings in the output, what about "
commands". I think "Admins Commands", "Client Commands" and "Daemon Commands"
would be much clearer than "Admin-type", "Client-type", and "Daemon-type".
Thoughts?
If we consider bash functions to be covered by the term "CLI programs" then
we're breaking compatibility even in a major release, but other than that the
only thing changing is the help output, so I don't think there's actually a
compatibility concern here. But I'm a +1 to put this in beta-1 anyway, if we
can address the two points above.
> Rework hadoop_usage to be broken up by clients/daemons/etc.
> -----------------------------------------------------------
>
> Key: HADOOP-13595
> URL: https://issues.apache.org/jira/browse/HADOOP-13595
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0-alpha2
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: HADOOP-13595.00.patch, HADOOP-13595.01.patch,
> HADOOP-13595.02.patch, HADOOP-13595.03.patch
>
>
> Part of the feedback from HADOOP-13341 was that it wasn't obvious what was a
> client and what was a daemon. Reworking the hadoop_usage output so that it
> is obvious helps fix this issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
