[
https://issues.apache.org/jira/browse/HADOOP-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079919#comment-16079919
]
Akira Ajisaka commented on HADOOP-14638:
----------------------------------------
The test failures is as follows:
{noformat}
org.mockito.exceptions.base.MockitoException:
Cannot mock/spy class org.slf4j.impl.Log4jLoggerAdapter
Mockito cannot mock/spy following:
- final classes
- anonymous classes
- primitive types
at
org.apache.hadoop.ha.TestShellCommandFencer.setupLogMock(TestShellCommandFencer.java:52)
{noformat}
org.slf4j.impl.Log4jLoggerAdapter is final, so we cannot spy it. I'll review
your patch.
> Replace commons-logging APIs with slf4j in StreamPumper
> -------------------------------------------------------
>
> Key: HADOOP-14638
> URL: https://issues.apache.org/jira/browse/HADOOP-14638
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Wenxin He
> Assignee: Wenxin He
> Attachments: HADOOP-14638.001.patch
>
>
> HADOOP-14539 is big, so we split a separate issue from HADOOP-14539.
> Now StreamPumper only accepts commons-logging logger API, so we should change
> StreamPumper api to accept slf4j and change the related code including some
> tests in TestShellCommandFencer that failed with slf4j.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
