[
https://issues.apache.org/jira/browse/HADOOP-14495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057369#comment-16057369
]
Steve Loughran commented on HADOOP-14495:
-----------------------------------------
Looks nice!
# good (implicit) question about what to do if a mandatory is overridden with
an optional. I go with your policy: downgrade.
# we can/should replace {{HadoopIllegalArgumentException with the base
{{IllegalArguentException}}, for better {{Preconditions}} checks.
# in {{TestLocalFileSystem}}, use {{LambdaTestUtils.intercept}} for your
assertion...the test code is a good place to start playing with closures.
# {{FileSystem}} 4150: does making that constructor package-private complicate
life for subclasses?
> Add set options interface to FSDataOutputStreamBuilder
> -------------------------------------------------------
>
> Key: HADOOP-14495
> URL: https://issues.apache.org/jira/browse/HADOOP-14495
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 3.0.0-alpha3
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HADOOP-14495.00.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
