[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047355#comment-16047355
]
Rushabh S Shah edited comment on HADOOP-14521 at 6/13/17 2:52 AM:
------------------------------------------------------------------
bq. For the retries, do you think maybe it's more intuitive to specify num of
failovers for the whole provider set?
>From [this comment, point
>1|https://issues.apache.org/jira/browse/HADOOP-14521?focusedCommentId=16036988&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16036988],
> I think [~daryn] had a good reason explaining why have fix number of retries
>is a good idea. I kind of agreed with him. So keeping the fix number of
>retries even in patch #7.
bq. KMSCP: the first @Link seems redundant
Fixed in v7
bq. Good to have some validations on the config params (e.g. numRetries > 0
etc.)
Added few pre conditions checks for all the config params.
bq.I'd revert the change that breaks instead of returning.
Thanks a lot for catching that. Fixed that in v7 of the patch.
was (Author: shahrs87):
bq. For the retries, do you think maybe it's more intuitive to specify num of
failovers for the whole provider set?
>From [this comment, point
>1|https://issues.apache.org/jira/browse/HADOOP-14521?focusedCommentId=16036988&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16036988],
> I think [~daryn] had a good reason explaining why have fix number of retries
>is a good idea. I kind of agreed with him. So keeping the fix number of
>retries even in patch #7.
bq. KMSCP: the first @Link seems redundant
Fixed in v7
bq. Good to have some validations on the config params (e.g. numRetries > 0
etc.)
Added few pre conditions checks for all the config params.
> KMS client needs retry logic
> ----------------------------
>
> Key: HADOOP-14521
> URL: https://issues.apache.org/jira/browse/HADOOP-14521
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Attachments: HDFS-11804-trunk-1.patch, HDFS-11804-trunk-2.patch,
> HDFS-11804-trunk-3.patch, HDFS-11804-trunk-4.patch, HDFS-11804-trunk-5.patch,
> HDFS-11804-trunk-6.patch, HDFS-11804-trunk-7.patch, HDFS-11804-trunk.patch
>
>
> The kms client appears to have no retry logic – at all. It's completely
> decoupled from the ipc retry logic. This has major impacts if the KMS is
> unreachable for any reason, including but not limited to network connection
> issues, timeouts, the +restart during an upgrade+.
> This has some major ramifications:
> # Jobs may fail to submit, although oozie resubmit logic should mask it
> # Non-oozie launchers may experience higher rates if they do not already have
> retry logic.
> # Tasks reading EZ files will fail, probably be masked by framework reattempts
> # EZ file creation fails after creating a 0-length file – client receives
> EDEK in the create response, then fails when decrypting the EDEK
> # Bulk hadoop fs copies, and maybe distcp, will prematurely fail
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
