[
https://issues.apache.org/jira/browse/HADOOP-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041579#comment-16041579
]
Sean Mackrory commented on HADOOP-14448:
----------------------------------------
>From the local Yetus run:
{quote}
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or
| | | | modified test files.
| +1 | mvninstall | 7m 40s | HADOOP-13345 passed
| +1 | compile | 0m 15s | HADOOP-13345 passed
| +1 | checkstyle | 0m 11s | HADOOP-13345 passed
| +1 | mvnsite | 0m 16s | HADOOP-13345 passed
| +1 | mvneclipse | 0m 12s | HADOOP-13345 passed
| 0 | findbugs | 0m 21s | hadoop-tools/hadoop-aws in HADOOP-13345
| | | | has 1 extant Findbugs warnings.
| +1 | javadoc | 0m 10s | HADOOP-13345 passed
| +1 | mvninstall | 0m 13s | the patch passed
| +1 | compile | 0m 13s | the patch passed
| +1 | javac | 0m 13s | the patch passed
| +1 | checkstyle | 0m 7s | the patch passed
| +1 | mvnsite | 0m 14s | the patch passed
| +1 | mvneclipse | 0m 10s | the patch passed
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | findbugs | 0m 22s | the patch passed
| +1 | javadoc | 0m 8s | the patch passed
| +1 | asflicense | 0m 10s | The patch does not generate ASF License
| | | | warnings.
{quote}
> Play nice with ITestS3AEncryptionSSEC
> -------------------------------------
>
> Key: HADOOP-14448
> URL: https://issues.apache.org/jira/browse/HADOOP-14448
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: HADOOP-13345
> Reporter: Sean Mackrory
> Assignee: Sean Mackrory
> Attachments: HADOOP-14448-HADOOP-13345.001.patch
>
>
> -HADOOP-14035 hasn't yet been merged with HADOOP-13345, but it adds tests
> that will break when run with S3Guard enabled-. It expects that certain
> filesystem actions will throw exceptions when the client-provided encryption
> key is not configured properly, but those actions may sometimes bypass S3
> entirely thanks to S3Guard (for example, getFileStatus may not actually need
> to invoke s3GetFileStatus). If the exception is never thrown, the test fails.
> At a minimum we should tweak the tests so they definitely invoke S3 directly,
> or just skip the offending tests when anything but the Null implementation is
> in use. This also opens the larger question of whether or not S3Guard should
> be serving up metadata that is otherwise only accessible when an encryption
> key is provided.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
