[
https://issues.apache.org/jira/browse/HADOOP-14492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041372#comment-16041372
]
Erik Krogen commented on HADOOP-14492:
--------------------------------------
[~cltlfcjin] I actually think that it is the {{NameNodeActivity}} metric which
is named in a misleading way. The RpcDetailedMetric is named after the RPC
call, which is in fact {{BlockReport}}. {{NameNodeActivity}} already has the
metric {{StorageBlockReportOps}} which has a more clear naming (though it is a
duplicate of {{BlockReportNumOps}}). It seems that we should deprecate
{{NameNodeActivity#BlockReportNumOps}} and change {{StorageBlockReportOps}} to
be a {{MutableRate}} to get both the count and the time, but this would be an
incompatible change. Perhaps with the 3.0 release would be a good time. I filed
a follow-on JIRA to discuss: HADOOP-14502. I will close this as JIRA as the
original purpose (addressing {{MutableRate}} vs
{{MutableRatesWithAggregation}}) is not an issue. Feel free to reopen if you
disagree.
> RpcDetailedMetrics and NameNodeMetrics use different rate metrics abstraction
> cause the Xavgtime confused
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-14492
> URL: https://issues.apache.org/jira/browse/HADOOP-14492
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Affects Versions: 2.8.0, 2.7.4
> Reporter: Lantao Jin
> Assignee: Erik Krogen
> Priority: Minor
>
> For performance purpose,
> [HADOOP-13782|https://issues.apache.org/jira/browse/HADOOP-13782] change the
> metrics behaviour in {{RpcDetailedMetrics}}.
> In 2.7.4:
> {code}
> public class RpcDetailedMetrics {
> @Metric MutableRatesWithAggregation rates;
> {code}
> In old version:
> {code}
> public class RpcDetailedMetrics {
> @Metric MutableRates rates;
> {code}
> But {{NameNodeMetrics}} still use {{MutableRate}} whatever in the new or old
> version:
> {code}
> public class NameNodeMetrics {
> @Metric("Block report") MutableRate blockReport;
> {code}
> It causes the metrics in JMX very different between them.
> {quote}
> name: "Hadoop:service=NameNode,name=RpcDetailedActivityForPort8030",
> modelerType: "RpcDetailedActivityForPort8030",
> tag.port: "8030",
> tag.Context: "rpcdetailed",
> ...
> BlockReportNumOps: 237634,
> BlockReportAvgTime: 1382,
> ...
> name: "Hadoop:service=NameNode,name=NameNodeActivity",
> modelerType: "NameNodeActivity",
> tag.ProcessName: "NameNode",
> ...
> BlockReportNumOps: 2592932,
> BlockReportAvgTime: 19.258064516129032,
> ...
> {quote}
> In the old version. They are correct.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
