[ 
https://issues.apache.org/jira/browse/HADOOP-14432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024742#comment-16024742
 ] 

Steve Loughran commented on HADOOP-14432:
-----------------------------------------

thanks, let's leave on trunk for now. There's no bug fixes in it, just tests 
and assertions. (OK one bug: you can copy onto a directory. But nobody has 
noticed :)

> S3A copyFromLocalFile to be robust, tested
> ------------------------------------------
>
>                 Key: HADOOP-14432
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14432
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>             Fix For: 3.0.0-alpha3
>
>         Attachments: HADOOP-14432-001.patch
>
>
> {{S3AFileSystem.copyFromLocalFile()}}
> Doesn't
> * check for local file existing. Fix: check and raise FNFE (today: 
> AmazonClientException is raised)
> * check for dest being a directory. Fix: Better checks before upload
> * have any tests. Fix: write the tests
> this is related to the committer work, but doesn't depend on it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to