[ 
https://issues.apache.org/jira/browse/HADOOP-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987708#comment-15987708
 ] 

Jason Lowe commented on HADOOP-14306:
-------------------------------------

Thanks for updating the patch, Eric!

Nit: I don't see the point of having a protected method for getting the test 
timeout value.  For {{AbstractFSContractTestBase}} it makes sense since the 
whole point of that class is to be subclassed by the "real" tests.  In this 
case nothing is going to subclass it, so it's just extra boilerplate with no 
purpose.

> TestLocalFileSystem tests have very low timeouts
> ------------------------------------------------
>
>                 Key: HADOOP-14306
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14306
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>         Attachments: HADOOP-14306.001.patch, HADOOP-14306.002.patch
>
>
> Most tests have a timeout of 1 second, which is much too low, especially if 
> there is a spinning disk involved. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to