[ 
https://issues.apache.org/jira/browse/HADOOP-14202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947281#comment-15947281
 ] 

Allen Wittenauer commented on HADOOP-14202:
-------------------------------------------

Thanks!

bq. Which feature requires Bash 3.2 ?

I changed this not so much for the changes made in this patch, but to get rid 
of the last shellcheck error in hadoop-config.sh while I was fixing the other 
ones.  That said, the one change in 3.2 I'm specifically targeting is this one:

{code}
The =~ Regular Expression match operator no longer requires quoting of the 
pattern within [[ ... ]].
{code}

We do this all over the place and if someone were to run this on 3.0 or 3.1, 
I'm fairly certain the world will tip over.

bq. 478: move to 2536?

{code}
  HADOOP_SUBCMD_SECURESERVICE=false
{code}

We set this here so that 3rd parties can override via shell profile later if 
they have some other way to do the work.  (e.g., maybe they overlay 
hadoop_secure_daemon_handler to use pfexec using RBAC instead of jsvc.  No 
extra pids or logs required, so a lot of this extra handling goes out the 
window.)

bq. Has HADOOP_SUBCMD_SECUREUSER become a local var in 
hadoop_generic_java_subcmd_handler?

Good catch.  I was thinking that it might be useful for 3rd parties (i.e. 
function replacement), but that doesn't make much sense.  HADOOP\_SECURE\_USER 
is really what they should be checking, even if the user later changes it via 
cmd\_subcmd\_SECURE\_USER.

> fix jsvc/secure user var inconsistencies
> ----------------------------------------
>
>                 Key: HADOOP-14202
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14202
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-14202.00.patch, HADOOP-14202.01.patch, 
> HADOOP-14202.02.patch
>
>
> Post-HADOOP-13341 and (more importantly) HADOOP-13673, there has been a major 
> effort on making the configuration environment variables consistent among all 
> the projects. The vast majority of vars now look like 
> (command)_(subcommand)_(etc). Two hold outs are HADOOP_SECURE_DN_USER  and 
> HADOOP_PRIVILEGED_NFS_USER.
> Additionally, there is
> * no generic handling
> * no documentation for anyone
> * no safety checks to make sure things are defined
> In order to fix all of this, we should:
> * deprecate the previous vars using the deprecation function, updating the 
> HDFS documentation that references them
> * add generic (command)_(subcommand)_SECURE_USER support
> * add some verification for the previously mentioned var
> * add some docs to UnixShellGuide.md



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to