[
https://issues.apache.org/jira/browse/HADOOP-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946203#comment-15946203
]
Hadoop QA commented on HADOOP-12528:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color}
| {color:red} HADOOP-12528 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-12528 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12769673/HADOOP-12528.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11985/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Avoid spinning in CallQueueManager.take()
> -----------------------------------------
>
> Key: HADOOP-12528
> URL: https://issues.apache.org/jira/browse/HADOOP-12528
> Project: Hadoop Common
> Issue Type: Improvement
> Components: performance
> Affects Versions: 2.7.1
> Reporter: Staffan Friberg
> Assignee: Staffan Friberg
> Priority: Minor
> Attachments: HADOOP-12528.001.patch, HADOOP-12528.002.patch
>
>
> When IPC threads (Server$Handler) does take() to get the next Call, the
> CallManager does a poll instead of take() on the internal queue.
> This causes threads to wake up and unnecessarily waste some CPU and do extra
> allocation as part of the internal await/signal mechanism each time the
> thread redoes poll().
> This patch uses take() on the queue instead of poll() which will keep thread
> in the await state until work is available. Since threads will be blocked on
> the queue indefinitely the swapping of queues requires a bit of extra work to
> make sure threads wake up and does take on the new queue.
> Updated the test TestCallQueueManager.testSwapUnderContention() to ensure
> that no threads get stuck on the old queue as part of swapping.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
