[
https://issues.apache.org/jira/browse/HADOOP-14223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944000#comment-15944000
]
Andrew Wang commented on HADOOP-14223:
--------------------------------------
Hi Manoj, thanks for working on this! Had a few review comments:
* I like adding hasAcl to FileStatus, since an FsPermission seems to
encapsulate just the Unix-style permissions. Seems like we have some
duplication now with the FsPermission getAclBit / getEncryptedBit /
getErausreCodedBit getters, perhaps we should deprecate them? getECBit we can
also annotate as Private. I'm hoping we can clean up these fields/getters in
FsPermission when HDFS-6984 goes in.
* I don't think toString should be required as part of assertErasureCoded in
ContractTestUtils, since as we discussed on HADOOP-13715, toString isn't part
of the public contract for a HCFS. It's fine to have toString asserts in Hadoop
or HDFS-specific tests though.
* Nit in filesystem.md: A given path only has a single ACL composed of multiple
AC entries, so I think "any ACLs" -> "an ACL". Another nit is that Encryption
or Erasure Coded aren't proper nouns, so I'd prefer them to be lower case.
{code:title=TestFileStatus}
if (fileStatus.hasAcl()) {
expected.append("hasAcl=").append(true).append("; ");
} else {
expected.append("hasAcl=").append(false).append("; ");
}
{code}
Could these be made more concise, e.g.
{code}
expected.append("hasAcl=").append(fileStatus.hasAcl()).append("; ");
{code}
> Extend FileStatus#toString() to include details like Erasure Coding and
> Encryption
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-14223
> URL: https://issues.apache.org/jira/browse/HADOOP-14223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.0.0-alpha1
> Reporter: Manoj Govindassamy
> Assignee: Manoj Govindassamy
> Attachments: HADOOP-14223.01.patch
>
>
> HDFS-6843 and HADOOP-13715 have enhanced {{FileStatus}} to include details on
> whether the underlying path is Encrypted and Erasure Coded. The additional
> details are embedded in the FsPermission high order bits. It would be really
> helpful for debugging if FileStatus#toString() returns these new bits details
> along with already existing one.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
