[ 
https://issues.apache.org/jira/browse/HADOOP-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Mackrory updated HADOOP-14125:
-----------------------------------
    Attachment: HADOOP-14125-HADOOP-13345.001.patch

Attaching a patch that works with testsThreadCount = cores / 2 on my machine. 
I've had failures in ITestS3ACredentialsInURL but I believe that's simply 
because DynamoDB can't get the credentials when they're only provided in the S3 
URL - surprisingly this doesn't ALWAYS fail, so I'm gonna dig into that deeper 
and file a JIRA.

I usually don't run parallel tests because I've always run testsThreadCount = 
cores * 2 and had a lot of failures. Currently: Various tests in 
ITestBlockingThreadPoolExecutorService ("Blocking call returned too fast") and 
various tests in ITestJets3tNativeFileSystemStore (files existing or not 
existing when expected, failures and tests that fail vary a lot).

> s3guard tool tests aren't isolated; can't run in parallel
> ---------------------------------------------------------
>
>                 Key: HADOOP-14125
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14125
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, test
>    Affects Versions: HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-14125-HADOOP-13345.001.patch
>
>
> The {{S3GuardToolTestBase}} don't parallelize and break other tests. This can 
> surface if you do a full run with -Ds3guard and -Ddynamo.
> # many of the test paths they create are being requested with absolute paths, 
> e.g {{"/test-diff"}}.
> # the base class doesn't  set up a per-forked-JUnit-test runner path in the 
> bucket
> # and there's no cleanup at the end of each test case; teardown() is empty.
> Ideally, the tests should be made child classes of  {{AbstractS3ATestBase}}, 
> with its post-run cleanup, If that can't be done, then the tests must 
> # use {{S3ATestUtils.createTestPath(super.getTestPath())}} to create the base 
> test path
> # clean up that dir in teardown if the FS instance is non-null. 
> {{ContractTestUtils.cleanup()}} can do this.
> If it happens that the tests cannot run in parallel with others, then the 
> build must be changed to exclude them from the parallel test run phase & 
> include them in the serialized section.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to