[
https://issues.apache.org/jira/browse/HADOOP-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876325#comment-15876325
]
Vishwajeet Dusane commented on HADOOP-14017:
--------------------------------------------
Thanks for the comment [~jzhuge].
1.
{quote}
#190-192, #88: Consider “oidOrUpn = enableUPN ? UserGroupRepresentation.UPN :
UserGroupRepresentation.OID;” and remove the initializer at #88. What do you
think?
{quote}
Are you suggesting?
{code}
private UserGroupRepresentation oidOrUpn;
...
oidOrUpn = enableUPN ? UserGroupRepresentation.UPN :
UserGroupRepresentation.OID;
{code}
instead of
{code}
private UserGroupRepresentation oidOrUpn = UserGroupRepresentation.OID;
...
if (enableUPN) {
oidOrUpn = UserGroupRepresentation.UPN;
}
{code}
2.
{quote}
Document the default value is false for the sake of performance
{quote}
Documentation is already there in patch 02 as
{noformat}
When false (default) : User and Group in FileStatus/AclStatus
response is represented by the unique identifier from Azure AD
profile (Object ID as GUID).
For performance optimization, Recommended default value.
{noformat}
Please let me know if you had different suggestion?
3.
{quote}
Mention that setOwner/setAcl accept both UPN and OID
{quote}
Good point. Will mention in the {{Features}} section.
4. Performance impact depends upon the number of unique user from the retrieved
list and if explicit look up is required with Azure AD for name resolution.
> User friendly name for ADLS user and group
> ------------------------------------------
>
> Key: HADOOP-14017
> URL: https://issues.apache.org/jira/browse/HADOOP-14017
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/adl
> Affects Versions: 3.0.0-alpha3
> Reporter: John Zhuge
> Assignee: Vishwajeet Dusane
> Attachments: HADOOP-14017.01.patch, HADOOP-14017.02.patch
>
>
> ADLS displays GUID whenever user or group displayed, e.g., {{ls}},
> {{getfacl}}.
> ADLS requires GUID whenever user or group input is needed, e.g., {{setfacl}},
> {{chown}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
